Unimplemented plugin #593
Merged
Unimplemented plugin #593
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
njooma
commented
Apr 24, 2024
Comment on lines
+126
to
+141
| buf.add("") | ||
| buf.add("") | ||
| buf.add("class Unimplemented{}Base({}Base):", service.name, service.name) | ||
| with buf.indent(): | ||
| for name, _, request_type, reply_type in service.methods: | ||
| buf.add("") | ||
| buf.add( | ||
| "async def {}(self, stream: '{}.{}[{}, {}]') -> None:", | ||
| name, | ||
| server.__name__, | ||
| server.Stream.__name__, | ||
| request_type, | ||
| reply_type, | ||
| ) | ||
| with buf.indent(): | ||
| buf.add("raise grpclib.exceptions.GRPCError(grpclib.const.Status.UNIMPLEMENTED)") |
There was a problem hiding this comment.
These are the lines I added compared to the grpclib version
njooma
commented
Apr 24, 2024
There was a problem hiding this comment.
I tested the new plugin by removing all the unimplemented methods from the RobotService. Everything still works as expected, and everything typechecks.
purplenicole730
approved these changes
Apr 25, 2024
stuqdog
approved these changes
Apr 26, 2024
Not really. The last time this file was updated was 10 months ago, and then 2 years ago, and then 4 years ago. So I don't think we lose much by bringing this in house. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
grpclib in python is not forwards compatible (see issue).
This was getting really annoying for people who didn't make gRPC changes, but had to deal with other people's changes because tests would fail.
So I made a protoc plugin that's the grpclib plugin with an added bit that will automatically generate an
UnimplementedServiceBasesimilar to how it happens in golang.This generated a fair few additional lines of code, but it's all generated boilerplate.
You still have to opt-in to using the unimplemented version by subclassing from it. Otherwise everything continues to work as normal. I'm considering making a PR upstream for this