Skip to content

RSDK-7195: fix no event loop logging error #579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

purplenicole730
Copy link
Member

@purplenicole730 purplenicole730 commented Apr 9, 2024

Tested with @thegreatco and confirmed that this fix works.

@purplenicole730 purplenicole730 marked this pull request as ready for review April 16, 2024 18:57
@purplenicole730 purplenicole730 requested a review from a team as a code owner April 16, 2024 18:57
Copy link
Member

@njooma njooma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Can you just add comments in the code describing why we have to do this please

Copy link
Member

@benjirewis benjirewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🧑‍🔧 .

@purplenicole730 purplenicole730 merged commit a2aafad into viamrobotics:main Apr 17, 2024
12 checks passed
@purplenicole730 purplenicole730 deleted the RSDK-7195-logging-error branch April 17, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants