-
Notifications
You must be signed in to change notification settings - Fork 56
[RDK-6642] Add examples to Camera component #537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Ale Paredes seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Warning your change may break code samples. If your change modifies any of the following functions please contact @viamrobotics/fleet-management. Thanks!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, one small comment but not blocking/no need to re-request review if you update
src/viam/components/camera/camera.py
Outdated
my_camera = Camera.from_robot(robot=robot, name="my_camera") | ||
|
||
# Assume "frame" has a mime_type of "image/vnd.viam.dep" | ||
frame = await my_camera.get_image() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps add this as the mime type as part of the request? I think that would showcase the method better
frame = await my_camera.get_image(mime_type = CameraMimeType.VIAM_RAW_DEPTH)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
RSDK-6642
Add code samples to the Camera component. The docs team will use this PR as an example on how to move the existing examples in docs.viam to the SDK.