-
Notifications
You must be signed in to change notification settings - Fork 56
RSDK-3788 - add getkinematics functionality in arm #335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RSDK-3788 - add getkinematics functionality in arm #335
Conversation
Warning your change may break code samples. If your change modifies any of the following functions please contact @viamrobotics/fleet-management. Thanks!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT! Just one comment about documentation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed from the perspective of the motion team rather than looking at code correctness/quality. A couple questions, but nothing big enough to hold this up over. Thanks for doing this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can this PR be renamed RSDK-3788 - XXXX
? The readme should also have an updated config json so the arm is part of it and works.
looks great! I would like to see some naming changes to be more consistent with other examples.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you update the example modules readme to reference this new example arm? and its config
No description provided.