Skip to content

RSDK-3788 - add getkinematics functionality in arm #335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

purplenicole730
Copy link
Member

No description provided.

@purplenicole730 purplenicole730 requested a review from raybjork June 28, 2023 15:18
@github-actions
Copy link
Contributor

Warning your change may break code samples. If your change modifies any of the following functions please contact @viamrobotics/fleet-management. Thanks!

component function
base {'func': 'is_moving'}
board {'func': 'gpio_pin_by_name', 'comment': 'Note that the pin supplied is a placeholder. Please change this to a valid pin you are using.', 'args': ['"16"']}
camera {'func': 'get_image'}
encoder {'func': 'get_position'}
motor {'func': 'is_moving'}
sensor {'func': 'get_readings'}
servo {'func': 'get_position'}
arm {'func': 'get_end_position'}
gantry {'func': 'get_lengths'}
gripper {'func': 'is_moving'}
movement_sensor {'func': 'get_linear_acceleration'}
input_controller {'func': 'get_controls'}
audio {'func': 'get_properties'}
pose_tracker {'func': 'get_poses'}
motion {'func': 'get_pose'}
vision {'func': 'get_classifications_from_camera', 'args': ['YOURCAMERANAME', '1'], 'comment': 'Note that the Camera supplied is a placeholder. Please change this to a valid Camera.'}

@purplenicole730 purplenicole730 marked this pull request as ready for review June 29, 2023 17:33
@purplenicole730 purplenicole730 requested a review from a team as a code owner June 29, 2023 17:33
@purplenicole730 purplenicole730 requested review from njooma, maximpertsov and cheukt and removed request for maximpertsov June 29, 2023 17:33
Copy link
Member

@njooma njooma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT! Just one comment about documentation

Copy link
Member

@raybjork raybjork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed from the perspective of the motion team rather than looking at code correctness/quality. A couple questions, but nothing big enough to hold this up over. Thanks for doing this!

Copy link
Member

@cheukt cheukt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can this PR be renamed RSDK-3788 - XXXX? The readme should also have an updated config json so the arm is part of it and works.
looks great! I would like to see some naming changes to be more consistent with other examples.

@purplenicole730 purplenicole730 changed the title Rsdk 3788 add getkinematics functionality in arm RSDK-3788 - add getkinematics functionality in arm Jun 29, 2023
@purplenicole730 purplenicole730 requested a review from cheukt June 29, 2023 19:08
Copy link
Member

@cheukt cheukt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the example modules readme to reference this new example arm? and its config

@purplenicole730 purplenicole730 requested a review from cheukt June 30, 2023 19:40
@purplenicole730 purplenicole730 merged commit 67704f1 into viamrobotics:main Jun 30, 2023
@purplenicole730 purplenicole730 deleted the RSDK-3788-add-getkinematics-functionality branch June 30, 2023 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants