Skip to content

Clarify base coordinate system in comments #324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 26, 2023

Conversation

JessamyT
Copy link
Contributor

Related to this docs ticket https://viam.atlassian.net/browse/DOCS-845

@JessamyT JessamyT requested a review from a team as a code owner June 16, 2023 01:42
@JessamyT JessamyT requested review from stuqdog and cheukt June 16, 2023 01:42
@github-actions
Copy link
Contributor

Warning your change may break code samples. If your change modifies any of the following functions please contact @viamrobotics/fleet-management. Thanks!

component function
base is_moving
board gpio_pin_by_name
camera get_image
encoder get_position
motor is_moving
sensor get_readings
servo get_position
arm get_end_position
gantry get_lengths
gripper is_moving
movement_sensor get_linear_acceleration
input_controller get_controls
audio get_properties
pose_tracker get_poses
motion get_pose
vision get_detector_names

Copy link
Member

@stuqdog stuqdog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JessamyT JessamyT requested a review from stuqdog June 21, 2023 16:41
@JessamyT
Copy link
Contributor Author

Changed per conversation with Rand

@JessamyT JessamyT merged commit bddd1ff into viamrobotics:main Jun 26, 2023
@JessamyT JessamyT deleted the basecoord branch June 26, 2023 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants