Skip to content

Automated Protos Update #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 13, 2023
Merged

Automated Protos Update #228

merged 4 commits into from
Mar 13, 2023

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Mar 2, 2023

This is an auto-generated PR to update proto definitions. Check the commits to see which repos and commits are responsible for the changes

@github-actions github-actions bot requested a review from a team as a code owner March 2, 2023 20:10
@github-actions github-actions bot requested a review from njooma March 2, 2023 20:10
@github-actions github-actions bot force-pushed the workflow/update-protos branch from a329621 to b2e4d41 Compare March 9, 2023 20:11
Copy link
Member

@cheukt cheukt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if tests pass and does allow the module to correctly start up

@benjirewis
Copy link
Member

Verified that the changes from my commit allow Python modules to return unimplemented errors that are swallowed here in RDK.

@github-actions github-actions bot force-pushed the workflow/update-protos branch from 3f3adae to 1248a90 Compare March 13, 2023 17:48
@benjirewis benjirewis requested a review from cheukt March 13, 2023 18:52
@njooma njooma merged commit 8b94c06 into main Mar 13, 2023
@njooma njooma deleted the workflow/update-protos branch March 13, 2023 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants