Repository navigation
Add start, end, and page_limit to get_robot_part_history - #1293
Merged
Julie Krasnick (jckras) merged 1 commit intoOct 15, 2026
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Julie Krasnick (jckras)
requested review from
Gabriel Gottlob (gabegottlob) and
Naveed Jooma (njooma)
and removed request for
Gabriel Gottlob (gabegottlob)
October 14, 2026 13:55
Member
|
👋 Thanks for requesting a review from the team! We aim to review PRs within one business day. If this is urgent |
Member
Author
|
Naveed Jooma (@njooma) I noticed the license finder test is failing on this pr for some reason? |
Ethan (stuqdog)
approved these changes
Oct 15, 2026
Member
These failures can be safely ignored, of the two libraries in question, one has an apache 2 license and the other has ISC which is functionally equvalent to MIT. |
Julie Krasnick (jckras)
merged commit Oct 15, 2026
f5f0672
into
viamrobotics:main
12 of 13 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds optional
start,end, andpage_limittoget_robot_part_historyso callers can fetch part history in pages instead of all at once. The server is about to default to 100 entries when no limit is sent (viamrobotics/app#13974), so this lets SDK users get past that.the changes are:
src/viam/app/app_client.py:get_robot_part_historytakes optionalstart,end, andpage_limitand passes them to the request. Existing calls behave the same.tests/mocks/services.py: the mock keeps the lastGetRobotPartHistoryRequestso tests can check it.tests/test_app_client.py: checks the new args reach the request, and that no limit is sent when they're omitted.testing:
uv run pytest tests/test_app_client.py🤖 Generated with Claude Code