Skip to content

Add start, end, and page_limit to get_robot_part_history - #1293

Merged
Julie Krasnick (jckras) merged 1 commit into
viamrobotics:mainfrom
jckras:part-history-pagination
Oct 15, 2026
Merged

Julie Krasnick (jckras) merged 1 commit into
viamrobotics:mainfrom
jckras:part-history-pagination

Conversation

@jckras

Copy link
Copy Markdown
Member

This PR adds optional start, end, and page_limit to get_robot_part_history so callers can fetch part history in pages instead of all at once. The server is about to default to 100 entries when no limit is sent (viamrobotics/app#13974), so this lets SDK users get past that.

the changes are:

  • src/viam/app/app_client.py: get_robot_part_history takes optional start, end, and page_limit and passes them to the request. Existing calls behave the same.
  • tests/mocks/services.py: the mock keeps the last GetRobotPartHistoryRequest so tests can check it.
  • tests/test_app_client.py: checks the new args reach the request, and that no limit is sent when they're omitted.

testing: uv run pytest tests/test_app_client.py

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@viambot

viambot commented Oct 14, 2026

Copy link
Copy Markdown
Member

👋 Thanks for requesting a review from the team!

We aim to review PRs within one business day. If this is urgent
or blocking you, please reach out in #team-sdk and
we'll prioritize it.

@jckras

Copy link
Copy Markdown
Member Author

Naveed Jooma (@njooma) I noticed the license finder test is failing on this pr for some reason?

@stuqdog

Copy link
Copy Markdown
Member

Naveed Jooma (Naveed Jooma (@njooma)) I noticed the license finder test is failing on this pr for some reason?

These failures can be safely ignored, of the two libraries in question, one has an apache 2 license and the other has ISC which is functionally equvalent to MIT.

@jckras
Julie Krasnick (jckras) merged commit f5f0672 into viamrobotics:main Oct 15, 2026
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants