Consolidate camera api demo #679
Draft
+75
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicksanford
force-pushed
the
consolidate-camera-api-demo
branch
from
fee1a7a to
22b850a
Compare
nicksanford
commented
Apr 30, 2025
Comment on lines
+17
to
41
| // returned. | ||
| rpc GetImage(GetImageRequest) returns (GetImageResponse) { | ||
| option deprecated = true; | ||
| option (google.api.http) = {get: "/viam/api/v1/component/camera/{name}/image"}; | ||
| } | ||
|
|
||
| rpc GetImages(GetImagesRequest) returns (GetImagesResponse) { | ||
| option deprecated = true; | ||
| option (google.api.http) = {get: "/viam/api/v1/component/camera/{name}/images"}; | ||
| } | ||
|
|
||
| // RenderFrame renders a frame from a camera of the underlying robot to an HTTP response. A specific MIME type | ||
| // can be requested but may not necessarily be the same one returned. | ||
| // RenderFrame renders a frame from a camera of the underlying robot to an | ||
| // HTTP response. A specific MIME type can be requested but may not | ||
| // necessarily be the same one returned. | ||
| rpc RenderFrame(RenderFrameRequest) returns (google.api.HttpBody) { | ||
| option deprecated = true; | ||
| option (google.api.http) = {get: "/viam/api/v1/component/camera/{name}/render_frame"}; | ||
| } | ||
|
|
||
| // GetPointCloud returns a point cloud from a camera of the underlying robot. A specific MIME type | ||
| // can be requested but may not necessarily be the same one returned. | ||
| // GetPointCloud returns a point cloud from a camera of the underlying robot. | ||
| // A specific MIME type can be requested but may not necessarily be the same | ||
| // one returned. | ||
| rpc GetPointCloud(GetPointCloudRequest) returns (GetPointCloudResponse) { | ||
| option deprecated = true; | ||
| option (google.api.http) = {get: "/viam/api/v1/component/camera/{name}/point_cloud"}; |
There was a problem hiding this comment.
We wouldn't deprecate these APIs immediately as part of this proposal, but rather, we would remove them at the end of the project once all important camera models have been migrated to the new API that can express all of them.
seanavery
reviewed
May 1, 2025
| rpc RenderFrame(RenderFrameRequest) returns (google.api.HttpBody) { | ||
| option deprecated = true; |
There was a problem hiding this comment.
Wondering why we needed this custom API endpoint for the frontend to begin with since the web app can handle GRPC responses.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.