Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OLED support for mechwild/murphpad. #98

Merged
merged 1 commit into from
Dec 30, 2021

Conversation

marcelmaltry
Copy link
Contributor

OLED on mechwild/murphpad:vial was not activated due to use of OLED_DRIVER_ENABLE instead of OLED_ENABLE in keymap.c.

@xyzz
Copy link
Contributor

xyzz commented Dec 24, 2021

Looks like the build is failing here

2021-12-24T19:55:33.3954184Z Checking file size of mechwild_murphpad_vial.hex                                                   
2021-12-24T19:55:33.3955204Z  * �[31;01mThe firmware is too large!�[0m 28862/28672 (190 bytes over)
2021-12-24T19:55:33.3967026Z  �[31;01m[ERRORS]�[0m

@marcelmaltry
Copy link
Contributor Author

Is there a particular reason why your CI uses avr-gcc (GCC) 5.4.0? The firmware compiles fine here locally with avr-gcc (Homebrew AVR GCC 8.4.0_2) 8.4.0.

 * The firmware size is approaching the maximum - 28324/28672 (98%, 348 bytes free)

@xyzz
Copy link
Contributor

xyzz commented Dec 24, 2021

It's using the qmkfm/base_container docker so that our CI matches qmk's -

container: qmkfm/base_container

there are plans to replace it with a unified toolchain (so we can ship same version of GCC for windows/mac/linux), though that's far away

* Disable Combos and Tap Dance to reduce firmware size.
@xyzz xyzz merged commit 0e5d31c into vial-kb:vial Dec 30, 2021
@marcelmaltry marcelmaltry deleted the fix_murphpad branch December 30, 2021 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants