Don't sort keys #236
Open
Don't sort keys #236
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@xyzz Maybe there are some side effects, why you can't accept this pull request? |
|
I have Ergohaven K03 keyboard with the problem. Remove the future can broke UX for users without the problem. What if allow define keys order by keyboard author. With fallback to current sort behaviour. |
Contributor
Author
The keyboard author will be able to define the order of the keys in the vial.json file. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have keyboard with layout like this.
Vial sorts keys by its coordinate x and y, and method
select_nextjumps to nearly random key.May be we can safely remove this feature?