Respect custom root path #19

JaycobA · 2015-03-06T14:32:42Z

sourcemaps working (rails 4.1)
respect relative_root_url setting
inherit from Sass::Rails to enable globbing

vhyza · 2015-03-17T11:10:14Z

Hello @JaycobA. I'm terribly sorry for the delay.

Unfortunately it's not working for rails 4.2. It seems Rails.configuration.relative_url_root is nil in new rails 4.2 project.

vhyza · 2015-03-17T11:11:48Z

lib/sass-rails-source-maps/sass_importer.rb

    def public_url(uri, sourcemap_dir = nil)
-      source_maps_directory = sourcemap_dir ? sourcemap_dir.sub(Rails.root.join('public').to_s, '') : "/#{SOURCE_MAPS_DIRECTORY}"
-      "#{source_maps_directory}/#{File.basename(uri)}"
+      url_root = Rails.configuration.relative_url_root.chomp('/')


We should probably have some default when Rails.configuration.relative_url_root is not set.

JaycobA added 3 commits March 6, 2015 13:49

add support for custom relative_url_root setting

e7fea1d

inherit SassImporter from Sass::Rails to allow Globbing

1eedfca

stop overwriting user settings

10a92a4

vhyza reviewed Mar 17, 2015
View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Respect custom root path #19

Respect custom root path #19

JaycobA commented Mar 6, 2015

vhyza commented Mar 17, 2015

vhyza Mar 17, 2015

Respect custom root path #19

Are you sure you want to change the base?

Respect custom root path #19

Conversation

JaycobA commented Mar 6, 2015

vhyza commented Mar 17, 2015

vhyza Mar 17, 2015

Choose a reason for hiding this comment