Add config APIs from notmuch 0.32 #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cool. Thanks a lot again. |
|
Hello, sorry to bug you about this again, but could I ask you to release 0.8.0? I'm afraid that the next release my crate is blocked by this API 🫥 Thank you! |
|
Released v0.8.0 just now. Sorry it took me so long. Thanks for your effort! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This kind of goes hand-in-hand with the
open_with_configPR I submitted recently. Thenotmuch_configfunctions are, confusingly, very different from thenotmuch_database_get_config_listfunction. These newer functions refer to the notmuch configuration file, rather than the database config (I think; they might also be an interface to the database config, but the API documentation wasn't too clear).Included are the safe API wrappers and unit tests. Also, this introduces the feature
"v0_32", which all the new API methods are tagged with, including theopen_with_configmethod. (My bad on not including it in that PR.)I think this probably warrants a notmuch-rs version 0.8.0 if I might suggest so :)