Add open_with_config #39
Merged
+194
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The other open functions have since been deprecated in the C API, and the current implementation of `open` in notmuch-rs doesn't support passing null pointers. Adding `open_with_config` and allowing it to accept `Option` types fixes this problem in a backwards-compatible way. I would have preferred to add a `String` to `NotmuchError` instead of creating `NotmuchVerboseError`, but I didn't want to break compatibility.
|
This looks good! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The other open functions have since been deprecated in the C API, and
the current implementation of
openin notmuch-rs doesn't supportpassing null pointers. Adding
open_with_configand allowing it toaccept
Optiontypes fixes this problem in a backwards-compatible way.I would have preferred to add a
StringtoNotmuchErrorinstead ofcreating
NotmuchVerboseError, but I didn't want to breakcompatibility.