Make sure groupDnProperty is requested from LDAP server#99
Merged
vesse merged 1 commit intovesse:masterfrom Jun 22, 2022
Merged
Conversation
Owner
|
Thanks, released in 5.0.3 |
Owner
|
Actually make that 5.0.4, the PR introduced a bug ( |
This was referenced Jun 23, 2022
Author
|
ah, my mistake
On Wednesday, June 22, 2022 at 03:10:56 p.m. EDT, Vesa Poikajärvi ***@***.***> wrote:
Actually make that 5.0.4, the PR introduced a bug (opts.attributes is not set always and caused TypeError: Cannot read properties of undefined (reading 'includes'))
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
This was referenced Jun 24, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
groupDnPropertyis accessed in the user returned by the user search when constructing the group search string, and so needs to be requested from the LDAP server.