Handle empty query stems safely in query side stemming - #36377
Merged
bratseth merged 2 commits intoApr 10, 2026
Merged
Conversation
Contributor
Author
|
Buildkite is still running. The Link checker failure appears to be workflow/infrastructure-related, not code-related: Could a maintainer please rerun the Link checker check when convenient? |
Contributor
Author
bratseth
reviewed
Apr 10, 2026
bratseth
left a comment
Member
There was a problem hiding this comment.
Consider these simplifications, otherwise LGTM!
bratseth
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements issue #33540.
This PR handles empty-stem query terms in query-side stemming with a narrow scope.
Changes:
Regression tests added for:
Verification:
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's
source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.