Skip to content

Remove sidebar from printed version #3912

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

vadimkatsel
Copy link
Contributor

So that's how printed version of the first page looks like now:

image

Is there any edits wanted, please, let me know.

@vadimkatsel vadimkatsel requested a review from lperry25 June 5, 2025 09:23
@ean
Copy link
Contributor

ean commented Jun 5, 2025

Is it possible to remove the hamburger-icon as well? And do something clever with the Vespa Cloud (?), hover does not work in a printed PDF, as-is it doesn't add too much value. Maybe some kind of styling would make it more clear that this is a Vespa Cloud-feature?

@lperry25
Copy link
Contributor

lperry25 commented Jun 5, 2025

Is it possible to remove the hamburger-icon as well? And do something clever with the Vespa Cloud (?), hover does not work in a printed PDF, as-is it doesn't add too much value. Maybe some kind of styling would make it more clear that this is a Vespa Cloud-feature?

Maybe we can just remove the vespa-cloud badge entirely since the title says vespa cloud in it?

@vadimkatsel
Copy link
Contributor Author

vadimkatsel commented Jun 5, 2025

Maybe some kind of styling would make it more clear that this is a Vespa Cloud-feature?

I can try to play with styling first and, at the very least, as @lperry25 said, we can just remove it from printed version.

@vadimkatsel vadimkatsel requested a review from ean June 5, 2025 11:28
@ean
Copy link
Contributor

ean commented Jun 6, 2025

Removing it sounds good to me!

@vadimkatsel
Copy link
Contributor Author

I've thought that we'd like to get rid of all kinds of the bages at that place. If not, please let me know, I'll quickly revert the changes.

Copy link
Contributor

@lperry25 lperry25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vadimkatsel we need to keep the badges, you should just hide them when the page is printed. they are important to differentiate between cloud and open source specific documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants