-
Notifications
You must be signed in to change notification settings - Fork 99
Remove sidebar from printed version #3912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Is it possible to remove the hamburger-icon as well? And do something clever with the Vespa Cloud (?), hover does not work in a printed PDF, as-is it doesn't add too much value. Maybe some kind of styling would make it more clear that this is a Vespa Cloud-feature? |
Maybe we can just remove the vespa-cloud badge entirely since the title says vespa cloud in it? |
I can try to play with styling first and, at the very least, as @lperry25 said, we can just remove it from printed version. |
Removing it sounds good to me! |
I've thought that we'd like to get rid of all kinds of the bages at that place. If not, please let me know, I'll quickly revert the changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vadimkatsel we need to keep the badges, you should just hide them when the page is printed. they are important to differentiate between cloud and open source specific documentation
So that's how printed version of the first page looks like now:
Is there any edits wanted, please, let me know.