Try to introduce concurrency to unit testing #975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dutor
changed the title
dutor
requested review from
CPWstatic,
critical27,
laura-ding,
monadbobo,
yixinglu and
darionyaphet
dutor
changed the title
|
Unit testing passed. |
1 similar comment
|
Unit testing passed. |
laura-ding
reviewed
Sep 26, 2019
yixinglu
reviewed
Sep 26, 2019
yixinglu
reviewed
Sep 26, 2019
|
Unit testing failed. |
laura-ding
approved these changes
Sep 27, 2019
|
Unit testing passed. |
1 similar comment
|
Unit testing passed. |
tong-hao
pushed a commit
to tong-hao/nebula
that referenced
this pull request
Jun 1, 2021
* Try to bring concurrency to unit testing * Fixed typo * Address @yixinglu's comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch reduces the chances of listen port conflicts, so that we can run unit tests concurrently, i.e
ctest --output-on-failure -jN. By doing this, the duration of unit testing could be reduced to 2 minutes from 12.