Modify the toHostAddr interface to support host resolved (gethostbyname). #935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…port the host name. Modify the toHostAddr interface to support host resolved (gethostbyname).
monadbobo
requested review from
dutor,
sherman-the-tank,
a user and
dangleptr
|
Unit testing failed. |
|
Jenkins go! |
|
Unit testing passed. |
laura-ding
previously approved these changes
Sep 16, 2019
dutor
reviewed
Sep 16, 2019
|
Unit testing passed. |
dutor
previously approved these changes
Sep 16, 2019
|
Wait a minute. Maybe It would be better to change the name of the interface accordingly to indicates that this function returns multiple IP addresses. Agree? |
Maybe we can split "toHostAddr(folly::StringPiece ip, int32_t port)" to two functions, getHostByName and getHostByAddr, and then call them in "toHostAddr(folly::StringPiece ipPort)"? |
|
Unit testing passed. |
…stname_issue931
|
Unit testing passed. |
CPWstatic
approved these changes
Dec 19, 2019
|
Unit testing passed. |
tong-hao
pushed a commit
to tong-hao/nebula
that referenced
this pull request
Jun 1, 2021
…me). (vesoft-inc#935) * Issue vesoft-inc#931 the "meta_server_addrs" in the configuration support the host name. Modify the toHostAddr interface to support host resolved (gethostbyname). * replace the gethostbyname with getaddrinfo. * Refactoring part of the code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #931