Support timestamp type #843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jenkins go |
|
Unit testing passed. |
laura-ding
requested review from
ayyt,
CPWstatic,
dutor,
dangleptr and
monadbobo
|
Unit testing passed. |
zlcook
previously approved these changes
Aug 29, 2019
dutor
previously approved these changes
Aug 29, 2019
CPWstatic
reviewed
Aug 29, 2019
|
Unit testing passed. |
critical27
reviewed
Sep 4, 2019
| LOG(FATAL) << "Unknown VariantType: " << record[i].which(); | ||
| if (colTypes[i] == SupportedType::UNKNOWN) { | ||
| switch (record[i].which()) { | ||
| case 0: |
There was a problem hiding this comment.
Maybe use the macro VAR_INT64?
There was a problem hiding this comment.
Another pr has done it
zlcook
approved these changes
Sep 5, 2019
critical27
approved these changes
Sep 6, 2019
|
Unit testing passed. |
yixinglu
pushed a commit
to yixinglu/nebula
that referenced
this pull request
Feb 16, 2020
* Add timestamp * fix vid * Address dutor's comment * Address CPWstatic's comment and Add type cast handle in TraverseExecutor
tong-hao
pushed a commit
to tong-hao/nebula
that referenced
this pull request
Jun 1, 2021
* Add timestamp * fix vid * Address dutor's comment * Address CPWstatic's comment and Add type cast handle in TraverseExecutor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #808