Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fsync upon closing WAL files #820

Merged
merged 3 commits into from
Aug 22, 2019
Merged

fsync upon closing WAL files #820

merged 3 commits into from
Aug 22, 2019

Conversation

lilydjwg
Copy link
Contributor

Or there will be possible data loss / corruption depending on the exact way how data is interpreted and handled. close doesn't mean automatic fsync.

@nebula-community-bot
Copy link
Member

Can one of the admins verify this patch?

@dutor
Copy link
Contributor

dutor commented Aug 21, 2019 •
edited
Loading

Thanks for this contribution.

@dutor dutor added the ready-for-testing PR: ready for the CI test label Aug 21, 2019
@dutor
Copy link
Contributor

dutor commented Aug 21, 2019

Jenkins, please run tests.

@nebula-community-bot
Copy link
Member

Unit testing passed.

dutor
dutor approved these changes Aug 21, 2019
View reviewed changes
Copy link
Contributor

@dutor dutor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kim_yes

dangleptr
dangleptr approved these changes Aug 21, 2019
View reviewed changes
Copy link
Contributor

@dangleptr dangleptr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done

@dangleptr
Copy link
Contributor

Jenkins go

@nebula-community-bot
Copy link
Member

Unit testing failed.

sherman-the-tank
sherman-the-tank approved these changes Aug 22, 2019
View reviewed changes
Copy link
Member

@sherman-the-tank sherman-the-tank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work!

@sherman-the-tank
Copy link
Member

jenkins go

@nebula-community-bot
Copy link
Member

Unit testing passed.

@dangleptr dangleptr merged commit 4e69a97 into vesoft-inc:master Aug 22, 2019
tong-hao pushed a commit to tong-hao/nebula that referenced this pull request Jun 1, 2021
@lilydjwg @dangleptr
fsync upon closing WAL files (vesoft-inc#820)
cea73ab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dutor dutor dutor approved these changes

@sherman-the-tank sherman-the-tank sherman-the-tank approved these changes

@dangleptr dangleptr dangleptr approved these changes

Assignees
No one assigned
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lilydjwg @nebula-community-bot @dutor @dangleptr @sherman-the-tank