Extend CAS in Raft #800
Merged
Extend CAS in Raft #800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dangleptr
commented
Aug 19, 2019
dangleptr
commented
- Support more atomic operations not only cas
- We could pass the atomic operator into raft, and it will be invoked atomically.
dangleptr
requested review from
sherman-the-tank,
zhangguoqing,
critical27 and
darionyaphet
|
Unit testing passed. |
critical27
reviewed
Aug 19, 2019
| auto casRet = compareAndSet(log); | ||
| if (casRet.empty()) { | ||
| [this] (AtomicOp op) -> std::string { | ||
| auto opRet = op(); |
There was a problem hiding this comment.
According to my understanding, in AtomicOp, user just define whatever they want to do atomically, and return the result as a string.
Why don't we just pass the AtomicOp instead of folly::Function<std::string(AtomicOp op)> opCB, it seems a little bit weird.
There was a problem hiding this comment.
Because we will set promise value, if we implement the logic directly in Iterator, you have to pass the whole part into it. This is not what we want.
|
Unit testing passed. |
tong-hao
pushed a commit
to tong-hao/nebula
that referenced
this pull request
Jun 1, 2021
liwenhui-soul
pushed a commit
to liwenhui-soul/nebula
that referenced
this pull request
May 10, 2022
* optimize bfs * optimizer allpath * optimizer multi-shortestpath * optimizer multi shortest path * fix validate unit test * add some comment * fix error * fix bfs error * add comment * delete conjunct * add findpath unit test * delete useless file * delete log * remove check * multi thread executor * single shortest multi thread * add some testcases * add gflags * fix bfs error * address comment Co-authored-by: jimingquan <mingquan.ji@vesoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.