Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed the WAL to call write() on every log message #729

Merged
merged 5 commits into from
Aug 26, 2019
Merged

Changed the WAL to call write() on every log message #729

merged 5 commits into from
Aug 26, 2019

Conversation

sherman-the-tank
Copy link
Member

We moved away from the memory buffered version. In this PR, every log message will be written to the system cache to prevent message loss due to the crash

fixed #531

@sherman-the-tank sherman-the-tank added the ready-for-testing PR: ready for the CI test label Aug 6, 2019
@sherman-the-tank
Copy link
Member Author

jenkins go

@nebula-community-bot
Copy link
Member

Unit testing passed.

@sherman-the-tank
Copy link
Member Author

@wadeliuyi Awesome comments 👍 I'll update the PR

@nebula-community-bot
Copy link
Member

Unit testing passed.

dangleptr
dangleptr reviewed Aug 9, 2019
View reviewed changes
Copy link
Contributor

@dangleptr dangleptr left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, we don't need a list of buffers. Just one buffer is enough. And the buffer should be a ring buffer. That's means it always keep the latest N logs inside.

dangleptr
dangleptr previously approved these changes Aug 13, 2019
View reviewed changes
Copy link
Contributor

@dangleptr dangleptr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done. Let's go

dutor
dutor reviewed Aug 15, 2019
View reviewed changes
@sherman-the-tank
Changed the WAL to call write on every log message
5387b90 
We moved away from the memory buffered version. In this PR, every log message will be written to the system cache to prevent message loss due to the crash

fixed #531
@sherman-the-tank
Addressed @wadeliuyi's comments and rebased
65197df
@sherman-the-tank
Addressed @dutor's, @wadeliuyi's, and @monadbobo's comments
4230226 
And rebased as well
@nebula-community-bot
Copy link
Member

Unit testing failed.

@sherman-the-tank
Copy link
Member Author

jenkins go

@nebula-community-bot
Copy link
Member

Unit testing passed.

@nebula-community-bot
Copy link
Member

Unit testing passed.

@nebula-community-bot
Copy link
Member

Unit testing passed.

@dangleptr dangleptr merged commit 166acae into vesoft-inc:master Aug 26, 2019
tong-hao pushed a commit to tong-hao/nebula that referenced this pull request Jun 1, 2021
@sherman-the-tank @dangleptr
Changed the WAL to call write() on every log message (vesoft-inc#729)
48bbe70 
We moved away from the memory buffered version. In this PR, every log message will be written to the system cache to prevent message loss due to the crash

fixed vesoft-inc#531
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@monadbobo monadbobo monadbobo left review comments

@dutor dutor dutor left review comments

@wadeliuyi wadeliuyi wadeliuyi left review comments

@critical27 critical27 critical27 approved these changes

@dangleptr dangleptr dangleptr approved these changes

Assignees
No one assigned
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Data loss due to WAL async flusher
7 participants
@sherman-the-tank @nebula-community-bot @monadbobo @dutor @critical27 @wadeliuyi @dangleptr