Enhance StoragePerf #721
Merged
Enhance StoragePerf #721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not only value size. Currently, one thread could sent at most 1000 requests. We should break the limit. One task could sent N requests each time. |
critical27
previously approved these changes
Aug 6, 2019
Merged
|
Can someone explain what's the purpose of this PR? |
darionyaphet
changed the title
|
In this PR I have support two features:
Maybe I should update it's title. @sherman-the-tank |
critical27
reviewed
Aug 20, 2019
| CHECK_GT(interval, 0) << "qpsPerThread should not large than 1000, interval " << interval; | ||
| int32_t radix = qpsPerThread / 1000; | ||
| int32_t slotSize = sizeof(slots_) / sizeof(int32_t); | ||
| if (qpsPerThread >= 1000) { |
There was a problem hiding this comment.
Maybe we don't need this if statement?
There was a problem hiding this comment.
Good catch & fixed :)
| @@ -51,6 +82,7 @@ class Perf { | |||
| CHECK(mClient_->waitForMetadReady()); | |||
| client_ = std::make_unique<StorageClient>(threadPool_, mClient_.get()); | |||
| time::Duration duration; | |||
| static uint32_t interval = 1; | |||
There was a problem hiding this comment.
I guess you mean 100ms here? According to my understanding, you split 1 second to 10 * 100ms, and set corresponding qps of each slot.
There was a problem hiding this comment.
10 ms is a cycle. slots_ is the sending plan for a cycle. So it should sleep 1 ms.
|
Unit testing passed. |
|
Unit testing passed. |
1 similar comment
|
Unit testing passed. |
dangleptr
approved these changes
Aug 24, 2019
| @@ -0,0 +1,28 @@ | |||
| ### Storage Perf Tool | |||
|
|
|||
| `_build/storage_perf` is the performance tool to test the storage service. | |||
critical27
approved these changes
Aug 26, 2019
|
Unit testing passed. |
1 similar comment
|
Unit testing passed. |
tong-hao
pushed a commit
to tong-hao/nebula
that referenced
this pull request
Jun 1, 2021
* data's size per request and multi message per request * append random message * fix dangleptr's comment
liwenhui-soul
pushed a commit
to liwenhui-soul/nebula
that referenced
this pull request
May 10, 2022
#### What type of PR is this? - [ ] bug - [x] feature - [ ] enhancement #### What does this PR do? #### Which issue(s)/PR(s) this PR relates to? close vesoft-inc#3448 #### Special notes for your reviewer, ex. impact of this fix, etc: #### Additional context: #### Checklist： - [x] Documentation affected （Please add the label if documentation needs to be modified.) - [ ] Incompatible （If it is incompatible, please describe it and add corresponding label.） - [ ] Need to cherry-pick （If need to cherry-pick to some branches, please label the destination version(s).) - [x] Performance impacted: Consumes more CPU/Memory #### Release notes： Please confirm whether to reflect in release notes and how to describe: > Support segment auto-increasing id ` Migrated from vesoft-inc#3550 Co-authored-by: jakevin <30525741+jackwener@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, support config data's size per message and multi message per request.