Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support variable/pipe reference in WHERE and YIELD #683

Merged
merged 3 commits into from
Aug 6, 2019
Merged

Support variable/pipe reference in WHERE and YIELD #683

merged 3 commits into from
Aug 6, 2019

Conversation

dutor
Copy link
Contributor

@dutor dutor commented Jul 24, 2019

As title.

This PR will close #432

@dutor dutor added the ready-for-testing PR: ready for the CI test label Jul 24, 2019
@nebula-community-bot
Copy link
Member

Unit testing passed.

@nebula-community-bot
Copy link
Member

Unit testing passed.

1 similar comment
@nebula-community-bot
Copy link
Member

Unit testing passed.

ASSERT_TRUE(verifyResult(resp, expected));
}
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should add GO N STEPS to test BackTracker.

@nebula-community-bot
Copy link
Member

Unit testing failed.

@dutor
Copy link
Contributor Author

dutor commented Jul 29, 2019

jenkins go for fun

@nebula-community-bot
Copy link
Member

Unit testing passed.

Copy link
Contributor

@laura-ding laura-ding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done

Copy link
Contributor

@CPWstatic CPWstatic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@nebula-community-bot
Copy link
Member

Unit testing passed.

@dutor dutor merged commit 572ee5d into vesoft-inc:master Aug 6, 2019
@dutor dutor deleted the var-in-where branch August 6, 2019 06:24
yixinglu pushed a commit to yixinglu/nebula that referenced this pull request Feb 16, 2020
tong-hao pushed a commit to tong-hao/nebula that referenced this pull request Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

how to take properties to the next hops?
4 participants