Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed false negative report when variable holds empty result #630

Merged
merged 3 commits into from
Jul 19, 2019
Merged

Fixed false negative report when variable holds empty result #630

merged 3 commits into from
Jul 19, 2019

Conversation

dutor
Copy link
Contributor

@dutor dutor commented Jul 15, 2019

As title.

@dutor dutor added the ready-for-testing PR: ready for the CI test label Jul 15, 2019
@nebula-community-bot
Copy link
Member

Unit testing passed.

laura-ding
laura-ding previously approved these changes Jul 15, 2019
View reviewed changes
Copy link
Contributor

@laura-ding laura-ding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a test to non-existent var

@dutor
Copy link
Contributor Author

dutor commented Jul 15, 2019

Could you add a test to non-existent var

Sure.

@nebula-community-bot
Copy link
Member

Unit testing passed.

laura-ding
laura-ding approved these changes Jul 15, 2019
View reviewed changes
Copy link
Contributor

@laura-ding laura-ding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a test to non-existent var

@nebula-community-bot
Copy link
Member

Unit testing passed.

@dutor dutor merged commit 5135258 into vesoft-inc:master Jul 19, 2019
@dutor dutor deleted the fix-var branch July 19, 2019 09:08
yixinglu pushed a commit to yixinglu/nebula that referenced this pull request Feb 16, 2020
@dutor
Fixed false negative report when variable holds empty result (vesoft-…
5a62530 
…inc#630)

* Fixed false negative report when variable holds empty result

* Address @laura-ding's comment
tong-hao pushed a commit to tong-hao/nebula that referenced this pull request Jun 1, 2021
@dutor
Fixed false negative report when variable holds empty result (vesoft-…
2ef4c96 
…inc#630)

* Fixed false negative report when variable holds empty result

* Address @laura-ding's comment
yixinglu pushed a commit to yixinglu/nebula that referenced this pull request Mar 21, 2022
@nebula-bots @Shylock-Hg @jackwener
Fix crash of null path expression. (vesoft-inc#630)
dd17982 
* Fix crash of null path expression.

* Add test case.

Co-authored-by: jakevin <30525741+jackwener@users.noreply.github.com>

Co-authored-by: shylock <33566796+Shylock-Hg@users.noreply.github.com>
Co-authored-by: jakevin <30525741+jackwener@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CPWstatic CPWstatic CPWstatic approved these changes

@laura-ding laura-ding laura-ding approved these changes

@monadbobo monadbobo Awaiting requested review from monadbobo

@jude-zhu jude-zhu Awaiting requested review from jude-zhu

Assignees
No one assigned
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dutor @nebula-community-bot @CPWstatic @laura-ding