Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

To be able to build under GCC 9.1 #588

Merged
merged 3 commits into from
Jul 9, 2019
Merged

To be able to build under GCC 9.1 #588

merged 3 commits into from
Jul 9, 2019

Conversation

dutor
Copy link
Contributor

@dutor dutor commented Jul 5, 2019

As title.

@dutor dutor added the ready-for-testing PR: ready for the CI test label Jul 5, 2019
@nebula-community-bot
Copy link
Member

Unit testing failed.

@dutor
Copy link
Contributor Author

dutor commented Jul 5, 2019

Due to the build time exceeded 30min.

Jenkins, go!

@nebula-community-bot
Copy link
Member

Unit testing passed.

1 similar comment
@nebula-community-bot
Copy link
Member

Unit testing passed.

laura-ding
laura-ding approved these changes Jul 9, 2019
View reviewed changes
Copy link
Contributor

@laura-ding laura-ding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done

@nebula-community-bot
Copy link
Member

Unit testing passed.

@dutor dutor merged commit 460d7f9 into vesoft-inc:master Jul 9, 2019
@dutor dutor deleted the build-under-gcc-9.1 branch July 9, 2019 07:42
yixinglu pushed a commit to yixinglu/nebula that referenced this pull request Feb 16, 2020
@dutor
To be able to build under GCC 9.1 (vesoft-inc#588)
ded03f8
tong-hao pushed a commit to tong-hao/nebula that referenced this pull request Jun 1, 2021
@dutor
To be able to build under GCC 9.1 (vesoft-inc#588)
5ff5dc4
yixinglu pushed a commit to yixinglu/nebula that referenced this pull request Mar 21, 2022
@nebula-bots @liwenhui-soul @critical27
refactor LOG and add comment for meta, meta/processors/job (vesoft-in…
f09ecf6 
…c#588)

* refactor LOG and add comment for meta, meta/processors/job

* refactor LOG and add comment for meta/processors/zone

Co-authored-by: Doodle <13706157+critical27@users.noreply.github.com>

Co-authored-by: liwenhui-soul <38217397+liwenhui-soul@users.noreply.github.com>
Co-authored-by: Doodle <13706157+critical27@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CPWstatic CPWstatic CPWstatic approved these changes

@laura-ding laura-ding laura-ding approved these changes

@monadbobo monadbobo Awaiting requested review from monadbobo

@darionyaphet darionyaphet Awaiting requested review from darionyaphet

@sherman-the-tank sherman-the-tank Awaiting requested review from sherman-the-tank

@zhangguoqing zhangguoqing Awaiting requested review from zhangguoqing

@critical27 critical27 Awaiting requested review from critical27

@dangleptr dangleptr Awaiting requested review from dangleptr

@boshengchen boshengchen Awaiting requested review from boshengchen

Assignees
No one assigned
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dutor @nebula-community-bot @CPWstatic @laura-ding