Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

To link executables with -no-pie #582

Merged
merged 2 commits into from
Jul 11, 2019
Merged

To link executables with -no-pie #582

merged 2 commits into from
Jul 11, 2019

Conversation

dutor
Copy link
Contributor

@dutor dutor commented Jul 4, 2019 •
edited
Loading

Some compilers are built with -enable-default-pie. That is no problem generally, but glog is buggy to deal with this when retrieve the backtrace. So we disable pie from our own side.

@dutor dutor added the ready-for-testing PR: ready for the CI test label Jul 4, 2019
@nebula-community-bot
Copy link
Member

Unit testing passed.

@monadbobo
Copy link
Contributor

Could you describe the problem caused by glog in more detail?

@dutor
Copy link
Contributor Author

dutor commented Jul 8, 2019

Could you describe the problem caused by glog in more detail?

Actually, glog introduced a bug that will cause the symbol resolve fail for PIE, which is exactly the version we are currently using, which has been fixed the the latest release.

@ayyt
Copy link
Contributor

ayyt commented Jul 8, 2019

Could you describe the problem caused by glog in more detail?

Actually, glog introduced a bug that will cause the symbol resolve fail for PIE, which is exactly the version we are currently using, which has been fixed the the latest release.

@dutor I have a question, why not use the latest version of glog ?

@dutor
Copy link
Contributor Author

dutor commented Jul 8, 2019

Could you describe the problem caused by glog in more detail?

Actually, glog introduced a bug that will cause the symbol resolve fail for PIE, which is exactly the version we are currently using, which has been fixed the the latest release.

@dutor I have a question, why not use the latest version of glog ?

First, it makes little sense to us to enable PIE, by default. Second, we should try our best to reduce mandatory requirements on our dependencies, especially when we have better options to deal with the problems.

FYI. we are going to move the third-party out from our repo.

@ayyt
Copy link
Contributor

ayyt commented Jul 8, 2019

Could you describe the problem caused by glog in more detail?

Actually, glog introduced a bug that will cause the symbol resolve fail for PIE, which is exactly the version we are currently using, which has been fixed the the latest release.

@dutor I have a question, why not use the latest version of glog ?

First, it makes little sense to us to enable PIE, by default. Second, we should try our best to reduce mandatory requirements on our dependencies, especially when we have better options to deal with the problems.

FYI. we are going to move the third-party out from our repo.

f1634089a5014f20919a619ed3eb2e2e

@monadbobo
Copy link
Contributor

LGTM!

monadbobo
monadbobo approved these changes Jul 11, 2019
View reviewed changes
Copy link
Contributor

@monadbobo monadbobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@nebula-community-bot
Copy link
Member

Unit testing passed.

@dutor dutor merged commit 07fa2ee into vesoft-inc:master Jul 11, 2019
@dutor dutor deleted the no-pie branch July 11, 2019 08:10
yixinglu pushed a commit to yixinglu/nebula that referenced this pull request Feb 16, 2020
@dutor
To link executables with -no-pie (vesoft-inc#582)
edeff4b
tong-hao pushed a commit to tong-hao/nebula that referenced this pull request Jun 1, 2021
@dutor
To link executables with -no-pie (vesoft-inc#582)
e46b8c4
yixinglu pushed a commit to yixinglu/nebula that referenced this pull request Mar 21, 2022
@wenhaocs @Sophie-Xie
Fix potential cache incoherence issue (vesoft-inc#582)
085280d 
* add lock at processor level

* add comments and fix issues in MockKVStore

* add lock to delete vertices, delete tags, and sync data

* remove todo comment

* fix in src/storage/kv/SyncDataProcessor.cpp

* fix SyncDataProcessor DeleteTagsProcessor DeleteVerticesProcessor

* fix scope

Conflicts:
	src/storage/exec/TagNode.h
	src/storage/exec/UpdateNode.h

* add lock to AddVerticesProcessor

* change lock scope in AddVerticesProcessor

* not use unique_ptr

* remove unique_ptr in AddVerticesProcesso

* remove unique_ptr to all other files

* remove comment in nebula store

* add override in indextestuils.h

Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@monadbobo monadbobo monadbobo approved these changes

@laura-ding laura-ding laura-ding approved these changes

@darionyaphet darionyaphet Awaiting requested review from darionyaphet

@sherman-the-tank sherman-the-tank Awaiting requested review from sherman-the-tank

@CPWstatic CPWstatic Awaiting requested review from CPWstatic

Assignees
No one assigned
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dutor @nebula-community-bot @monadbobo @ayyt @laura-ding