Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed or adjusted permissions on installed files #578

Merged
merged 3 commits into from
Jul 19, 2019
Merged

Fixed or adjusted permissions on installed files #578

merged 3 commits into from
Jul 19, 2019

Conversation

dutor
Copy link
Contributor

@dutor dutor commented Jul 3, 2019

As title.

@dutor dutor added the ready-for-testing PR: ready for the CI test label Jul 4, 2019
@nebula-community-bot
Copy link
Member

Unit testing passed.

FILES
utils.sh
PERMISSIONS
OWNER_WRITE OWNER_READ
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why utils.sh does not need executable permissions here?

Copy link
Contributor Author

@dutor dutor Jul 14, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As its name indicating, this is a collection of utilities, so the file is not going to be executed directly.

Copy link
Contributor

@laura-ding laura-ding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done

@nebula-community-bot
Copy link
Member

Unit testing passed.

@dutor dutor merged commit 1df8375 into vesoft-inc:master Jul 19, 2019
@dutor dutor deleted the fix-permissions branch July 19, 2019 10:34
yixinglu pushed a commit to yixinglu/nebula that referenced this pull request Feb 16, 2020
tong-hao pushed a commit to tong-hao/nebula that referenced this pull request Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants