Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed 'required' keyword in hbase.thrift and other minors #573

Merged
merged 2 commits into from
Jul 4, 2019
Merged

Removed 'required' keyword in hbase.thrift and other minors #573

merged 2 commits into from
Jul 4, 2019

Conversation

dutor
Copy link
Contributor

@dutor dutor commented Jul 3, 2019 •
edited
Loading

  1. Remvoved required in hbase.thrift to suppresss warnings
  2. Removed test on common/test/ServerContext, since it is being used and tested in other tests
  3. Removed dependency on storage from inside meta

This will close #558

laura-ding
laura-ding approved these changes Jul 3, 2019
View reviewed changes
Copy link
Contributor

@laura-ding laura-ding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done

@dutor dutor added the ready-for-testing PR: ready for the CI test label Jul 3, 2019
dangleptr
dangleptr approved these changes Jul 4, 2019
View reviewed changes
Copy link
Contributor

@dangleptr dangleptr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nebula-community-bot
Copy link
Member

Unit testing passed.

@dutor dutor merged commit 695b232 into vesoft-inc:master Jul 4, 2019
@dutor dutor deleted the minor-changes branch July 4, 2019 03:11
yixinglu pushed a commit to yixinglu/nebula that referenced this pull request Feb 16, 2020
@dutor
Removed 'required' keyword in hbase.thrift and other minors (vesoft-i…
218b057 
…nc#573)
tong-hao pushed a commit to tong-hao/nebula that referenced this pull request Jun 1, 2021
@dutor
Removed 'required' keyword in hbase.thrift and other minors (vesoft-i…
165c1f5 
…nc#573)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dangleptr dangleptr dangleptr approved these changes

@laura-ding laura-ding laura-ding approved these changes

@sherman-the-tank sherman-the-tank Awaiting requested review from sherman-the-tank

@zhangguoqing zhangguoqing Awaiting requested review from zhangguoqing

@CPWstatic CPWstatic Awaiting requested review from CPWstatic

Assignees
No one assigned
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix compile warnings in hbase.thrift.
4 participants
@dutor @nebula-community-bot @dangleptr @laura-ding