To deal with illegal characters in parser #572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dutor
requested review from
CPWstatic,
laura-ding,
monadbobo,
whitewum and
sherman-the-tank
whitewum
reviewed
Jul 4, 2019
| @@ -374,6 +374,9 @@ TEST(Scanner, Basic) { | |||
| CHECK_SEMANTIC_VALUE("\"\\\\\\\110 \"", TokenType::STRING, "\\H "), | |||
| CHECK_SEMANTIC_VALUE("\"\\\\\\\\110 \"", TokenType::STRING, "\\\\110 "), | |||
| CHECK_SEMANTIC_VALUE("\"\\\\\\\\\110 \"", TokenType::STRING, "\\\\H "), | |||
|
|
|||
|
|
|||
| CHECK_SEMANTIC_VALUE("\"己所不欲，勿施于人\"", TokenType::STRING, "己所不欲，勿施于人"), | |||
There was a problem hiding this comment.
before the fix, does this sentence make service crash?
My point is can you re-produce the problem. I'm not sure the bug is due to non-asiic code
There was a problem hiding this comment.
It's another story. You could refer to discussions in #562 for details.
|
Unit testing passed. |
whitewum
approved these changes
Jul 11, 2019
| } | ||
| "#".* // Skip the annotation | ||
| "//".* // Skip the annotation | ||
| "--".* // Skip the annotation | ||
| "/*" { BEGIN(COMMENT); } | ||
| <COMMENT>"*/" { BEGIN(INITIAL); } | ||
| <COMMENT>([^*]|\n)+|. // Skip the annotation | ||
| . { printf("error %c\n", *yytext); yyterminate(); } | ||
| . { | ||
| /** |
|
Unit testing passed. |
yixinglu
pushed a commit
to yixinglu/nebula
that referenced
this pull request
Feb 16, 2020
tong-hao
pushed a commit
to tong-hao/nebula
that referenced
this pull request
Jun 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title.
This will close #562