Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support to return score from es query #5580

Merged
merged 14 commits into from
Jun 8, 2023

Conversation

yixinglu
Copy link
Contributor

@yixinglu yixinglu commented Jun 7, 2023

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

LOOKUP ON edge2 where es_query(nebula_index_edge2_prop1, "abc") YIELD id(edge) as id, score() as sc |
LIMIT 3,2

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@yixinglu yixinglu added the ready-for-testing PR: ready for the CI test label Jun 7, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jun 7, 2023

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 34.66667% with 98 lines in your changes missing coverage. Please review.

Project coverage is 77.61%. Comparing base (209d0bf) to head (6db0ac0).
Report is 83 commits behind head on master.

Files with missing lines Patch % Lines
...mizer/rule/PushLimitDownFulltextIndexScanRule2.cpp 14.03% 49 Missing ⚠️
src/graph/planner/ngql/LookupPlanner.cpp 3.84% 25 Missing ⚠️
src/graph/validator/LookupValidator.cpp 81.39% 8 Missing ⚠️
...graph/executor/query/FulltextIndexScanExecutor.cpp 0.00% 7 Missing ⚠️
src/graph/planner/plan/Query.h 0.00% 5 Missing ⚠️
src/common/function/FunctionManager.cpp 71.42% 2 Missing ⚠️
src/graph/planner/plan/Query.cpp 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5580      +/-   ##
==========================================
+ Coverage   77.00%   77.61%   +0.61%     
==========================================
  Files        1129     1130       +1     
  Lines       85247    85333      +86     
==========================================
+ Hits        65643    66233     +590     
+ Misses      19604    19100     -504     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yixinglu yixinglu marked this pull request as ready for review June 7, 2023 11:49
@yixinglu yixinglu requested review from dutor and codesigner as code owners June 7, 2023 11:49
@Shinji-IkariG Shinji-IkariG merged commit 62c14e9 into vesoft-inc:master Jun 8, 2023
@yixinglu yixinglu deleted the es-score branch June 8, 2023 03:38
yixinglu added a commit to yixinglu/nebula that referenced this pull request Sep 14, 2023
* Ft search (vesoft-inc#5567)

* Add optimizer rule for pushing limit into the fulltext index scan (vesoft-inc#5575)

* Merge limit and full text index scan rule (vesoft-inc#5577)

* Support to return score from es query (vesoft-inc#5580)

* modify ft search (vesoft-inc#5584)

* modify ft search

* fix bug

* address some comment

* fix bug

* fix conflict

---------

Co-authored-by: hs.zhang <22708345+cangfengzhs@users.noreply.github.com>
Co-authored-by: Yee <2520865+yixinglu@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants