Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support to ASAN #55

Merged
merged 2 commits into from
Jan 2, 2019
Merged

Add support to ASAN #55

merged 2 commits into from
Jan 2, 2019

Conversation

dutor
Copy link
Contributor

@dutor dutor commented Dec 28, 2018 •
edited
Loading

I had only tested with -DRelWithDebInfo, in Fedora 29. Before enabled by default in Jenkins, I will ensure it passes in the Centos 7 environment.

Two leaks were found, all blame to me.

Besides, following cases failed. It seems due to linking with jemalloc. I will remove this dependency when built with ASAN in future PRs.

The following tests FAILED:
         18 - part_test (SEGFAULT)
         19 - rocksdb_engine_test (SEGFAULT)
         20 - kvstore_test (SEGFAULT)
         29 - add_vertices_test (SEGFAULT)

With this PR merged, you could run tests under AddressSanitizer if built with cmake -Dsanitize=ON .

Happy New Year!

@nebula-community-bot
Copy link
Member

Build succeeded.

sherman-the-tank
sherman-the-tank approved these changes Dec 31, 2018
View reviewed changes
Copy link
Member

@sherman-the-tank sherman-the-tank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

Love it!!!

@nebula-community-bot
Copy link
Member

Build succeeded.

@dutor dutor merged commit 65dd18b into vesoft-inc:master Jan 2, 2019
@dutor dutor deleted the asan branch January 3, 2019 08:53
yixinglu pushed a commit to yixinglu/nebula that referenced this pull request Feb 16, 2020
@dutor
Add partial support to ASAN (vesoft-inc#55)
bfb84c3
tong-hao pushed a commit to tong-hao/nebula that referenced this pull request Jun 1, 2021
@dutor
Add partial support to ASAN (vesoft-inc#55)
ed1eaed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sherman-the-tank sherman-the-tank sherman-the-tank approved these changes

@dangleptr dangleptr Awaiting requested review from dangleptr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dutor @nebula-community-bot @sherman-the-tank