Update docs on Docker's registry mirrors #511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darionyaphet
previously approved these changes
Jun 11, 2019
|
LGTM |
dutor
reviewed
Jun 11, 2019
dutor
reviewed
Jun 11, 2019
docs/get-started.md
Outdated
|
|
||
| ``` | ||
| docker --version | ||
| ``` | ||
|
|
||
| If `docker` is not found, please see [here](https://docs.docker.com/install/) for more information to install docker. | ||
| If `Docker` is not found, please see [here](https://docs.docker.com/install/) for more information to install Docker. |
There was a problem hiding this comment.
Thanks for your patient review and professional suggestions, I've learned a lot. Have fixed all the backtick and expression.
docs/get-started.md
Outdated
| `Docker` is a tool designed to make it easier to create, deploy, and run applications by using containers. | ||
| Containers allow a developer to package up an application with all of the parts it needs, | ||
| such as libraries and other dependencies, and ship it all out as one package. | ||
| By doing so, the developer can rest assured that the application will run on any other `Linux` machine regardless of any customized settings that machine might have that could differ from the machine used for writing and testing the code. | ||
|
|
||
| First of all, you should make sure that `docker` has been installed on your machine. Open a terminal and run the following command : | ||
| First of all, you should make sure that `Docker` has been installed on your machine. Open a terminal and run the following command : |
docs/get-started.md
Outdated
| @@ -7,29 +7,41 @@ This tutorial provides a quick introduction to use `Nebula Graph`. | |||
|
|
|||
| ### Step 1 Install Nebula Graph | |||
|
|
|||
| The easiest way to startup `nebula` is using `docker`. | |||
| The easiest way to startup `Nebula` is using `Docker`. | |||
| `Docker` is a tool designed to make it easier to create, deploy, and run applications by using containers. | |||
docs/get-started.md
Outdated
|
|
||
| After that, using | ||
| ``` | ||
| docker pull vesoft/nebula-graph:latest | ||
| ``` | ||
| to get `nebula` image and `docker images` that can display images status. | ||
| to get `Nebula` image and `Docker images` that can display images status. |
There was a problem hiding this comment.
ditto.
Besides, here the docker is a command, so it should be in backticks and cannot be capitalized.
docs/get-started.md
Outdated
|
|
||
| If `docker` is slow when pulling the image, configure an accelerator. | ||
| If `Docker` is slow when pulling the image, configure a new mirror. |
There was a problem hiding this comment.
Ditto.
Besides, what is slow is the very pulling action itself, but not Docker.
dutor
approved these changes
Jun 19, 2019
darionyaphet
approved these changes
Jun 21, 2019
|
Jenkins, go! |
|
Unit testing failed. |
|
jenkins go |
|
Unit testing passed. |
whitewum
approved these changes
Jun 26, 2019
|
Unit testing passed. |
dutor
changed the title
tong-hao
pushed a commit
to tong-hao/nebula
that referenced
this pull request
Jun 1, 2021
* add docker accelerator detail * Fix expressions and monospace * fix backticks and expression
yixinglu
pushed a commit
to yixinglu/nebula
that referenced
this pull request
Mar 21, 2022
* Set expression depth limit by flag. * Format. Co-authored-by: Yichen Wang <18348405+Aiee@users.noreply.github.com> Co-authored-by: shylock <33566796+Shylock-Hg@users.noreply.github.com> Co-authored-by: Yichen Wang <18348405+Aiee@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add 'config docker accelerator detail' in get-started