Fix empty prop of tag and edge #505

laura-ding · 2019-06-10T10:44:23Z

Delete [] of SRC_REF and DST_REF
Fix insert vertex and edge when tag or edge has the empty prop

whitewum · 2019-06-11T09:41:01Z

src/graph/test/DataTest.cpp

+    }
+    {
+        cpp2::ExecutionResponse resp;
+        std::string cmd = "CREATE EDGE work()";


add some cases:

create edge e1(); create edge e2();

create tag t1(); create e1();

a very very long sentence /* or repeatly add 1000 times */

@whitewum 👍

3. a very very long sentence /* or repeatly add 1000 times */

You inspired me, I have a few small questions:

Is there a limit to the length of the SQL statement?

Is there a limit on the number of tag/edge columns?

Is there a limit to the length of each record when inserting vertex/edge?

Good! Add tests to cover this limits (and will not be changed by others in the future.)

whitewum · 2019-06-11T09:45:51Z

src/graph/test/DataTest.cpp

+    // Get result
+    {
+        cpp2::ExecutionResponse resp;
+        std::string cmd = "GO FROM 10001 OVER work yield $$company.name";


add some case:
try to get a property which does not exist;

whitewum · 2019-06-11T11:23:04Z

src/graph/test/SchemaTest.cpp

        cpp2::ExecutionResponse resp;
-        std::string query = "DESCRIBE TAG not_exist";
+        std::string query = "CREATE EDGE edge1()";


add case:
alter edge1 without property to add a property.

laura-ding · 2019-06-12T00:22:29Z

close #453

ayyt · 2019-06-12T08:45:35Z

src/graph/test/DataTest.cpp

+        std::string cmd = "ADD HOSTS " + host;
+        auto code = client_->execute(cmd, resp);
+        if (cpp2::ErrorCode::SUCCEEDED != code) {
+            return TestError() << "Do cmd:" << cmd << " failed";


What about ”Execute cmd“ ？

laura-ding · 2019-06-25T09:34:53Z

close #436

nebula-community-bot · 2019-06-27T07:44:55Z

Unit testing passed.

whitewum · 2019-07-06T04:04:20Z

any updates for this PR? @laura-ding Ready for review?

Add UTs

laura-ding · 2019-07-06T08:48:44Z

@whitewum No anything to update, but should resolve conflicts.

nebula-community-bot · 2019-07-06T09:22:39Z

Unit testing passed.

whitewum

Great!
Please add more tests as comment inline.

src/common/filter/Expressions.cpp

src/graph/test/OrderByTest.cpp

whitewum · 2019-07-08T03:02:12Z

src/graph/test/OrderByTest.cpp

@@ -61,7 +61,7 @@ TEST_F(OrderByTest, NoInput) {
        cpp2::ExecutionResponse resp;
        auto &player = players_["Nobody"];
        auto *fmt = "GO FROM %ld OVER serve YIELD "
-                    "$^[player].name as name, serve.start_year as start, $$[team].name as name"
+                    "$^player.name as name, serve.start_year as start, $$team.name as name"


src/graph/test/SchemaTest.cpp

whitewum · 2019-07-08T03:07:57Z

src/graph/test/SchemaTest.cpp

+    {
+        cpp2::ExecutionResponse resp;
+        std::string query;
+        for (auto i = 0u; i < 1000; i++) {


whitewum · 2019-07-08T03:11:52Z

src/graph/test/SchemaTest.cpp

+        auto code = client->execute(query, resp);
+        ASSERT_EQ(cpp2::ErrorCode::SUCCEEDED, code);
+    }
+    {


let's suppose tag100~tag101000 have been created.
then let's

drop tag10100~tag10300.

alter tag10400~tag10500
let's check the results.

-> not existed

-> changed

-> others, remain unchanged.

dutor

Good one.

But in my opinion, it would be better to adapt the syntax to like $$.tag_name.prop_name(including $^), which is more conform to other similar constructs such as $var and $-.

nebula-community-bot · 2019-07-08T12:06:24Z

Unit testing passed.

dutor

LGTM.

whitewum · 2019-07-09T03:13:42Z

src/graph/test/OrderByTest.cpp

@@ -61,7 +61,7 @@ TEST_F(OrderByTest, NoInput) {
        cpp2::ExecutionResponse resp;
        auto &player = players_["Nobody"];
        auto *fmt = "GO FROM %ld OVER serve YIELD "
-                    "$^player.name as name, serve.start_year as start, $$team.name as name"
+                    "$^.player.name as name, serve.start_year as start, $$.team.name as name"


src/graph/test/SchemaTest.cpp

nebula-community-bot · 2019-07-09T03:53:11Z

Unit testing failed.

nebula-community-bot · 2019-07-09T04:49:35Z

Unit testing passed.

) * Support empty property * Delete [] of SRC_REF and DST_REF Add UTs * Address whitewum's comment * rebase upstream * Address dutor's comment * Fix toString()

* Fix typos * Add periodical license check and refactor License class interface * Change check interval to 12 hours * Remove unnecessary variable definition * Add exit routine in the periodically check * Fix license check in stand alone daemon * Raise signal to terminate the process gracefully

laura-ding changed the title ~~Fix empty prop~~ Fix empty prop of tag and edge Jun 10, 2019

whitewum reviewed Jun 11, 2019

View reviewed changes

whitewum previously approved these changes Jun 11, 2019

View reviewed changes

laura-ding dismissed whitewum’s stale review via a696976 June 12, 2019 03:46

ayyt reviewed Jun 12, 2019

View reviewed changes

laura-ding added the ready-for-testing PR: ready for the CI test label Jun 19, 2019

laura-ding added 3 commits July 6, 2019 14:41

Support empty property

1bf424a

Delete [] of SRC_REF and DST_REF

3142acb

Add UTs

Address whitewum's comment

fad11e9

rebase upstream

aeea343

whitewum previously approved these changes Jul 8, 2019

View reviewed changes

dutor reviewed Jul 8, 2019

View reviewed changes

Address dutor's comment

6c40e32

laura-ding dismissed whitewum’s stale review via 6c40e32 July 8, 2019 09:41

Fix toString()

b8440e4

dutor approved these changes Jul 9, 2019

View reviewed changes

whitewum approved these changes Jul 9, 2019

View reviewed changes

Merge branch 'master' into FixEmptyProp

34aaba8

dutor merged commit 9d58989 into vesoft-inc:master Jul 9, 2019

laura-ding deleted the FixEmptyProp branch October 30, 2019 11:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix empty prop of tag and edge #505

Fix empty prop of tag and edge #505

laura-ding commented Jun 10, 2019

whitewum Jun 11, 2019

ayyt Jun 12, 2019

whitewum Jun 19, 2019

whitewum Jun 11, 2019

laura-ding Jun 11, 2019

whitewum Jun 11, 2019

laura-ding Jun 11, 2019

laura-ding commented Jun 12, 2019

ayyt Jun 12, 2019

laura-ding commented Jun 25, 2019

nebula-community-bot commented Jun 27, 2019

whitewum commented Jul 6, 2019

laura-ding commented Jul 6, 2019

nebula-community-bot commented Jul 6, 2019

whitewum left a comment

whitewum Jul 8, 2019

whitewum Jul 8, 2019

whitewum Jul 8, 2019

dutor left a comment •

edited

Loading

nebula-community-bot commented Jul 8, 2019

dutor left a comment

whitewum Jul 9, 2019

nebula-community-bot commented Jul 9, 2019

nebula-community-bot commented Jul 9, 2019

Fix empty prop of tag and edge #505

Fix empty prop of tag and edge #505

Conversation

laura-ding commented Jun 10, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

laura-ding commented Jun 12, 2019

Choose a reason for hiding this comment

laura-ding commented Jun 25, 2019

nebula-community-bot commented Jun 27, 2019

whitewum commented Jul 6, 2019

laura-ding commented Jul 6, 2019

nebula-community-bot commented Jul 6, 2019

whitewum left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dutor left a comment • edited Loading

Choose a reason for hiding this comment

nebula-community-bot commented Jul 8, 2019

dutor left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nebula-community-bot commented Jul 9, 2019

nebula-community-bot commented Jul 9, 2019

dutor left a comment •

edited

Loading