Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/pattern expression ref local variable #4498

Conversation

Shylock-Hg
Copy link
Contributor

@Shylock-Hg Shylock-Hg commented Aug 9, 2022

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

Support pattern expression reference local defined variable, implement this by filter path in list(the result of pattern expressioin)

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@Shylock-Hg Shylock-Hg requested review from jievince and czpmango August 9, 2022 01:46
@Shylock-Hg Shylock-Hg added the ready-for-testing PR: ready for the CI test label Aug 9, 2022
@Shylock-Hg Shylock-Hg requested a review from nevermore3 August 9, 2022 01:57
@Shylock-Hg Shylock-Hg requested a review from jievince August 9, 2022 09:03
@codecov-commenter
Copy link

Codecov Report

Merging #4498 (933396d) into master (b20964a) will increase coverage by 0.16%.
The diff coverage is 83.22%.

@@            Coverage Diff             @@
##           master    #4498      +/-   ##
==========================================
+ Coverage   84.56%   84.72%   +0.16%     
==========================================
  Files        1344     1348       +4     
  Lines      134121   134355     +234     
==========================================
+ Hits       113414   113834     +420     
+ Misses      20707    20521     -186     
Impacted Files Coverage Δ
src/graph/executor/StorageAccessExecutor.h 62.22% <ø> (-2.23%) ⬇️
src/graph/executor/query/AppendVerticesExecutor.h 100.00% <ø> (ø)
src/graph/executor/query/GetEdgesExecutor.h 100.00% <ø> (ø)
src/graph/executor/query/GetNeighborsExecutor.h 100.00% <ø> (ø)
src/graph/executor/query/GetVerticesExecutor.h 100.00% <ø> (ø)
src/graph/service/PermissionCheck.cpp 81.63% <ø> (+0.38%) ⬆️
src/graph/validator/FetchEdgesValidator.h 100.00% <ø> (ø)
.../graph/validator/test/GetSubgraphValidatorTest.cpp 100.00% <ø> (ø)
src/graph/visitor/RewriteSymExprVisitor.cpp 26.33% <0.00%> (+0.11%) ⬆️
src/meta/processors/job/BalanceJobExecutor.cpp 66.66% <ø> (+1.51%) ⬆️
... and 92 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Sophie-Xie Sophie-Xie merged commit 02d6380 into vesoft-inc:master Aug 16, 2022
@Shylock-Hg Shylock-Hg deleted the feature/pattern-expression-ref-local-variable branch August 16, 2022 02:29
@dutor dutor mentioned this pull request Nov 9, 2022
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants