Optimize GQLParser by using raw buffer instead of istream #445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dutor
requested review from
darionyaphet,
sherman-the-tank,
dangleptr,
boshengchen and
laura-ding
|
Jenkins, please run tests. |
|
Unit testing failed. |
|
Unit testing passed. |
boshengchen
reviewed
May 27, 2019
boshengchen
reviewed
May 27, 2019
|
Unit testing failed. |
Due to failure in raft, jenkins please run tests again! |
|
Unit testing passed. |
boshengchen
previously approved these changes
May 29, 2019
|
Unit testing passed. |
|
Unit testing passed. |
|
Unit testing failed. |
|
Jenkins, go! |
|
Unit testing passed. |
yixinglu
pushed a commit
to yixinglu/nebula
that referenced
this pull request
Feb 16, 2020
…#445) * Optimize GQLParser by using raw buffer instead of istream * Fixed ScannerTest * Fixed an memory leak on parsing failure
tong-hao
pushed a commit
to tong-hao/nebula
that referenced
this pull request
Jun 1, 2021
…#445) * Optimize GQLParser by using raw buffer instead of istream * Fixed ScannerTest * Fixed an memory leak on parsing failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now, there are still two instances of
std::istream(yyin) andstd::ostream(yyout) left in theyyFlexLexerclass, i.e. the base class ofGraphScanner, which is provided by Flex, which we cannot optimize them away directly.For a workaround, we could make the whole parser reentrant, even on the failure cases, so that the parser could be used as a static, thread-local instance.