Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cmake command error in nightly workflow #4114

Merged
merged 1 commit into from
Apr 2, 2022

Conversation

yixinglu
Copy link
Contributor

@yixinglu yixinglu commented Apr 2, 2022

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

This failure is introduced in #4105

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

None

@yixinglu yixinglu added ready-for-testing PR: ready for the CI test cherry-pick-v3.1 PR: need cherry-pick to this version labels Apr 2, 2022
@yixinglu yixinglu requested review from Aiee, czpmango and jievince April 2, 2022 04:12
@Shinji-IkariG Shinji-IkariG merged commit daaed0a into vesoft-inc:master Apr 2, 2022
Sophie-Xie pushed a commit that referenced this pull request Apr 3, 2022
CPWstatic added a commit that referenced this pull request Apr 3, 2022
* fix memory leak (#4103)

* Param MATCH vid seek fix (#4024)

* Add qctx to isEvaluableExpr for kRelIn

Fixing MATCH (n) WHERE id(n) IN [$t] RETURN n

* Fix eq kVal parameter vidseek

* Fix id(n) IN [$var] case

* lint add explicit and remove tailing semicolon

* clang-format-10

* double check type of rightListValue

Addressing Kyle's review comment

* ut added in features/yield/parameter.feature

* support kAttribute

match (n) where n in $list_var return n

* Add kSubscript for eq case

MATCH (v) WHERE id(v) == $p7.a.b.d[4] RETURN v

Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com>
Co-authored-by: kyle.cao <kyle.cao@vesoft.com>
Co-authored-by: cpw <13495049+CPWstatic@users.noreply.github.com>

* disable console pkg (#4110)

* disable console pkg

* fix

* disable console pkg (#4112)

* Fix service crash caused by using function call as a part of the filter in `LOOKUP` (#4111)

* Fix function call purity check

* Add UT for purity check

* Add TCK cases

* Fix cmake command error (#4114)

Co-authored-by: yaphet <4414314+darionyaphet@users.noreply.github.com>
Co-authored-by: Wey Gu <weyl.gu@gmail.com>
Co-authored-by: kyle.cao <kyle.cao@vesoft.com>
Co-authored-by: cpw <13495049+CPWstatic@users.noreply.github.com>
Co-authored-by: Yichen Wang <18348405+Aiee@users.noreply.github.com>
Co-authored-by: Yee <2520865+yixinglu@users.noreply.github.com>
@yixinglu yixinglu deleted the fix-cmake-error branch December 19, 2022 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-v3.1 PR: need cherry-pick to this version ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants