Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Query] Support Description about Graph Space #388

Merged
merged 25 commits into from
May 23, 2019
Merged

[Query] Support Description about Graph Space #388

merged 25 commits into from
May 23, 2019

Conversation

darionyaphet
Copy link
Contributor

Reopen Support Description about Graph Space

nebula> describe space nba
=================================================
| ID | Name | Partition number | Replica Factor |
=================================================
|  1 |  nba |                1 |              1 |
-------------------------------------------------

@darionyaphet darionyaphet added the ready-for-testing PR: ready for the CI test label May 16, 2019
@nebula-community-bot
Copy link
Member

Unit testing failed.

@darionyaphet darionyaphet removed the ready-for-testing PR: ready for the CI test label May 16, 2019
@darionyaphet darionyaphet added the ready-for-testing PR: ready for the CI test label May 16, 2019
@darionyaphet
Copy link
Contributor Author

jenkins go

@nebula-community-bot
Copy link
Member

Unit testing passed.

@nebula-community-bot
Copy link
Member

Unit testing passed.

dutor
dutor previously approved these changes May 17, 2019
Copy link
Contributor

@dutor dutor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@nebula-community-bot
Copy link
Member

Unit testing passed.

@nebula-community-bot
Copy link
Member

Unit testing failed.

@darionyaphet
Copy link
Contributor Author

jenkins go

@nebula-community-bot
Copy link
Member

Unit testing failed.

@nebula-community-bot
Copy link
Member

Unit testing failed.

@nebula-community-bot
Copy link
Member

Unit testing passed.

Copy link
Contributor

@dangleptr dangleptr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are too many extra copy in your code. You should take care of them.

@nebula-community-bot
Copy link
Member

Unit testing passed.

dangleptr
dangleptr previously approved these changes May 21, 2019
Copy link
Contributor

@dangleptr dangleptr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done

@nebula-community-bot
Copy link
Member

Unit testing failed.

@nebula-community-bot
Copy link
Member

Unit testing passed.

@laura-ding laura-ding merged commit 2993756 into vesoft-inc:master May 23, 2019
@darionyaphet darionyaphet deleted the desc-space branch July 25, 2019 10:00
yixinglu pushed a commit to yixinglu/nebula that referenced this pull request Feb 16, 2020
* support describe space

* support describe space

* support desc space

* address dangleptr's comment

* address dutor's comment

* using async

* address dangleptr's comment

* fix

* fix copyright

* address dangleptr's comment

* fix

* fix
tong-hao pushed a commit to tong-hao/nebula that referenced this pull request Jun 1, 2021
* support describe space

* support describe space

* support desc space

* address dangleptr's comment

* address dutor's comment

* using async

* address dangleptr's comment

* fix

* fix copyright

* address dangleptr's comment

* fix

* fix
yixinglu pushed a commit to yixinglu/nebula that referenced this pull request Mar 21, 2022
Co-authored-by: Harris.Chu <1726587+HarrisChu@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants