Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete src/common/encryption src/common/base/stringunorderedmap #3867

Merged
merged 2 commits into from
Feb 10, 2022
Merged

delete src/common/encryption src/common/base/stringunorderedmap #3867

merged 2 commits into from
Feb 10, 2022

Conversation

jiayuehua
Copy link
Contributor

What type of PR is this?

  • bug
  • feature
  • [*] enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

delete src/common/encryption

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@jiayuehua jiayuehua added the ready-for-testing PR: ready for the CI test label Feb 8, 2022
@Aiee
Copy link
Contributor

Aiee commented Feb 8, 2022

Please check the license.h in the enterprise version to verify if this change is compatible.

@jiayuehua
Copy link
Contributor Author

Please check the license.h in the enterprise version to verify if this change is compatible.

https://github.com/vesoft-inc/nebula-ent/blob/master/src/common/encryption/License.h?

@Aiee
Copy link
Contributor

Aiee commented Feb 8, 2022

Please check the license.h in the enterprise version to verify if this change is compatible.

https://github.com/vesoft-inc/nebula-ent/blob/master/src/common/encryption/License.h?

Yes, some of the methods in encryption module are used in license validation, please check license.cpp

@critical27 critical27 merged commit 7a4ee56 into vesoft-inc:master Feb 10, 2022
@jiayuehua jiayuehua deleted the encryption branch February 10, 2022 03:06
liwenhui-soul pushed a commit to liwenhui-soul/nebula that referenced this pull request Feb 15, 2022
Aiee pushed a commit to Aiee/nebula that referenced this pull request Mar 14, 2022
@Sophie-Xie Sophie-Xie added the cherry-pick-v3.0 PR: need cherry-pick to this version label Mar 14, 2022
yixinglu pushed a commit that referenced this pull request Mar 14, 2022
* unify leader change and machine not found (#4022)

Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com>

* delete src/common/encryption src/common/base/stringunorderedmap (#3867)

* delete src/common/encryption

* encryption format code

* Update error message when connect with an out-of-date client (#4021)

* Update error message

* Do clientAddr check before FLAGS_enable_authorize check

* Fix typo

Co-authored-by: yaphet <4414314+darionyaphet@users.noreply.github.com>
Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com>
Co-authored-by: yuehua.jia <3423893+jiayuehua@users.noreply.github.com>
@jiayuehua
Copy link
Contributor Author

#3774

yixinglu pushed a commit to yixinglu/nebula that referenced this pull request Mar 21, 2022
…ft-inc#600)

* delete src/common/encryption src/common/base/stringunorderedmap (vesoft-inc#3867)

* delete src/common/encryption

* encryption format code

* delete base64.h line

* base64decode

* base64decode

* base64decode

* base64decode

* revert cmakefiles

* revert storage cmakelist.txt

* revert tools cmakelists.txt

* revert simple kv verify

* revert CMakeLists.txt

Co-authored-by: yuehua.jia <3423893+jiayuehua@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-v3.0 PR: need cherry-pick to this version ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants