Replace group when create space #3321
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darionyaphet
force-pushed
the
white-list-key
branch
2 times, most recently
from
900e136 to
5b26585
Compare
darionyaphet
force-pushed
the
white-list-key
branch
4 times, most recently
from
f16299a to
b5ff7c5
Compare
darionyaphet
requested review from
panda-sheep,
critical27,
liuyu85cn and
a team
|
use this to mark checkbox~ |
SuperYoko
reviewed
Nov 18, 2021
| if (sentence->groupName()) { | ||
| spaceDesc_.set_group_name(std::move(*(sentence->groupName()))); | ||
| if (sentence->zoneNames()) { | ||
| spaceDesc_.set_zone_names(std::move(sentence->zoneNames()->zoneNames())); |
There was a problem hiding this comment.
why ->zoneNames()->zoneNames()? just curious. looks wired.
There was a problem hiding this comment.
It's just typed conversion and return the std::vectorstd::string
There was a problem hiding this comment.
compile error by clang here. no need std::move
SuperYoko
reviewed
Nov 18, 2021
darionyaphet
force-pushed
the
white-list-key
branch
from
676427b to
b5ff7c5
Compare
|
rely on add host to fix describe space |
darionyaphet
force-pushed
the
white-list-key
branch
from
b5ff7c5 to
ec6a8d1
Compare
|
This PR have merged into White list so close it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do?
Which issue(s)/PR(s) this PR relates to?
Special notes for your reviewer, ex. impact of this fix, etc:
Additional context:
Checklist：
Release notes：
Please confirm whether to reflect in release notes and how to describe: