Multi paths. #3318
Merged
Multi paths. #3318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czpmango
reviewed
Nov 18, 2021
Comment on lines
47
to
+50
| matchClauseCtx->aliasesUsed = aliasesUsed; | ||
| NG_RETURN_IF_ERROR(validatePath(matchClause->path(), *matchClauseCtx)); | ||
| if (matchClause->path()->pathSize() > 1) { | ||
| return Status::SemanticError("Multi paths not supported."); | ||
| } |
There was a problem hiding this comment.
The data structure of MatchClauseContext may need to be redesigned.
nevermore3
approved these changes
Nov 22, 2021
yixinglu
approved these changes
Nov 22, 2021
czpmango
approved these changes
Nov 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What does this PR do?
Partial work of implementing OpenCypher.
Which issue(s)/PR(s) this PR relates to?
Partial work of implementing OpenCypher.
Special notes for your reviewer, ex. impact of this fix, etc:
Additional context:
Checklist：
Release notes：
Please confirm whether to reflect in release notes and how to describe: