Refactor the insertion syntax #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dutor
requested review from
ayyt,
boshengchen,
dangleptr,
darionyaphet and
sherman-the-tank
|
Unit testing passed. |
ayyt
reviewed
May 7, 2019
|
Unit testing passed. |
|
Unit testing passed. |
ayyt
approved these changes
May 8, 2019
|
user should specify |
Do you mean the vertex id? If so, yeah, its value and semantics is absolutely up to the users, thus must be provided. |
dangleptr
approved these changes
May 10, 2019
| // TODO(dutor) To support multi-tag insertion | ||
| auto tagItems = sentence_->tagItems(); | ||
| if (tagItems.size() > 1) { | ||
| return Status::Error("Multi-tag not supported yet"); |
There was a problem hiding this comment.
It seems the executor needs a big change to support multi-tag insertion.
|
Unit testing passed. |
yixinglu
pushed a commit
to yixinglu/nebula
that referenced
this pull request
Feb 16, 2020
* Refactor the insertion syntax * Fixed missing overwritable in vertex insertion
tong-hao
pushed a commit
to tong-hao/nebula
that referenced
this pull request
Jun 1, 2021
* Refactor the insertion syntax * Fixed missing overwritable in vertex insertion
yixinglu
added a commit
to yixinglu/nebula
that referenced
this pull request
Mar 21, 2022
* exec sequencial querys (vesoft-inc#194) exec sequencial querys * change: parser whitelist * white list * whitelist - add whitelist processor * ip whitelist - extract checker before password * ip whitelist - alter user ip whitelist * ip whitelist - log * style format * check licenses * check licenses * add tests * format * show users with ip whitelist * test and spell * Delete nebula.license delete license * add tck cases * style * fix some comments * fix test * modify parser Co-authored-by: haifei.zhao <32253291+zhaohaifei@users.noreply.github.com> Co-authored-by: Yee <2520865+yixinglu@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title.
Now the syntaxes are like: