Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dss part8: move PropertyType to common.thrift #3222

Merged

Conversation

panda-sheep
Copy link
Contributor

@panda-sheep panda-sheep commented Oct 27, 2021

What type of PR is this?

  • bug
  • feature

Which issue(s) this PR fixes:

close #xxx
(If it is requirement, issue(s) number must be listed.)

What this PR does / why we need it?

Move PropertyType from meta.thrift to common.thrift for drainer to use.

Special notes for your reviewer, ex. impact of this fix, etc:

Additional context:

Checklist:

  • Documentation affected (If need to modify document, please label it.)
  • Incompatible (If it is incompatile, please describle it and label it.)
  • Need to cherry pick (If need to cherry pick to some branchs, please label the destination version(s).)
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory

Release notes:

Please confirm whether to reflect in release notes and how to describe:

                                                            `

@panda-sheep panda-sheep force-pushed the move_PropertyType_to_common branch from 76ec504 to eadf0dc Compare October 27, 2021 08:56
@panda-sheep panda-sheep changed the title move PropertyType to common.thrift Dss part8: move PropertyType to common.thrift Oct 27, 2021
@critical27 critical27 merged commit 1de911d into vesoft-inc:master Oct 28, 2021
@panda-sheep panda-sheep deleted the move_PropertyType_to_common branch October 28, 2021 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants