Skip to content

Fix bugs in storage #277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 16, 2019
Merged

Fix bugs in storage #277

merged 1 commit into from
Apr 16, 2019

Conversation

dangleptr
Copy link
Contributor

Two bugs:

  1. Use rank and dstId to identify last edge during collectEdgeProps
  2. Use Max - now for version in vertex key.

@dangleptr dangleptr requested a review from dutor April 16, 2019 03:55
dutor
dutor approved these changes Apr 16, 2019
View reviewed changes
Copy link
Contributor

@dutor dutor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@nebula-community-bot
Copy link
Member

Unit testing passed.

@dutor dutor merged commit ef7f604 into vesoft-inc:master Apr 16, 2019
@dutor dutor deleted the bug branch April 16, 2019 05:50
tong-hao pushed a commit to tong-hao/nebula that referenced this pull request Jun 1, 2021
@dangleptr @dutor
Fix bugs in storage (vesoft-inc#277)
c052c0d
yixinglu added a commit to yixinglu/nebula that referenced this pull request Mar 21, 2022
@nebula-bots @yixinglu
fix a bug may stuck (vesoft-inc#276) (vesoft-inc#277)
1253634 
* fix a bug may stuck

* update

Co-authored-by: Yee <2520865+yixinglu@users.noreply.github.com>

Co-authored-by: lionel.liu@vesoft.com <lionel.liu@vesoft.com>
Co-authored-by: Yee <2520865+yixinglu@users.noreply.github.com>

Co-authored-by: lionel.liu@vesoft.com <lionel.liu@vesoft.com>
Co-authored-by: Yee <2520865+yixinglu@users.noreply.github.com>
yixinglu pushed a commit to yixinglu/nebula that referenced this pull request Mar 21, 2022
@jackwener
Revert "fix a bug may stuck (vesoft-inc#276) (vesoft-inc#277)" (vesof…
1c9529e 
…t-inc#279)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dutor dutor dutor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dangleptr @nebula-community-bot @dutor