Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the link order of libraries #246

Merged
merged 1 commit into from
Mar 29, 2019
Merged

fix the link order of libraries #246

merged 1 commit into from
Mar 29, 2019

Conversation

w41ter
Copy link
Contributor

@w41ter w41ter commented Mar 28, 2019

Both libglog and libjemalloc depend on libunwind and should be linked before libunwind.

@nebula-community-bot
Copy link
Member

Can one of the admins verify this patch?

@dutor
Copy link
Contributor

dutor commented Mar 28, 2019

Thank you for taking care of this.

I noticed that the proxygen package has been changed. Why is that?

@w41ter
Copy link
Contributor Author

w41ter commented Mar 28, 2019

I only modified the proxygen/configurate.ac file in the proxygen package, and the changes were added to the build.sh file.

# LIBS="$LIBS $BOOST_LDFLAGS -lpthread -pthread -lfolly -lglog"
# ==>
# LIBS="$LIBS $BOOST_LDFLAGS -lpthread -pthread"	

in the original version, i noticed link scripts like :

./.libs/libproxygenhttp.a ../services/.libs/libproxygenservices.a -lwangle -lfolly -lz -levent -lgflags -lssl -lcrypto -ldl -lunwind -lglog -ldouble-conversion -lboost_context -lboost_system -lboost_thread -pthread

and message given by the linker:

/nebula/third-party/glog/_install/lib/libglog.a(libglog_la-utilities.o): In function `google::GetStackTrace(void**, int, int) [clone .part.7]':
utilities.cc:(.text+0x9a): undefined reference to `_Ux86_64_getcontext'
utilities.cc:(.text+0xa5): undefined reference to `_ULx86_64_init_local'
utilities.cc:(.text+0xc7): undefined reference to `_ULx86_64_step'
utilities.cc:(.text+0xe0): undefined reference to `_ULx86_64_get_reg'
utilities.cc:(.text+0xff): undefined reference to `_ULx86_64_step'

@dutor dutor requested a review from sherman-the-tank March 28, 2019 23:12
@dutor
Copy link
Contributor

dutor commented Mar 28, 2019

Jenkins, please run tests

@nebula-community-bot
Copy link
Member

Unit testing passed.

Copy link
Contributor

@dutor dutor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

xiefeiji

@dutor dutor merged commit 8a9b056 into vesoft-inc:master Mar 29, 2019
yixinglu pushed a commit to yixinglu/nebula that referenced this pull request Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants