Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add edge rank & fix test case #2337

Merged
merged 3 commits into from
Sep 7, 2020
Merged

add edge rank & fix test case #2337

merged 3 commits into from
Sep 7, 2020

Conversation

nevermore3
Copy link
Contributor

@nevermore3 nevermore3 commented Sep 4, 2020

What changes were proposed in this pull request?

add rank field to the test case

Why are the changes needed?

Avoid covering multiple edges of the same type

Will break the compatibility? How if so?

no

Does this PR introduce any user-facing change?

no

How was this patch tested?

Comparison with 2.0 test cases

Checklist

  • I've run the tests to see all new and existing tests pass
  • If this Pull Request resolves an issue, I linked to the issue in the text above
  • I've informed the technical writer about the documentation change if necessary

laura-ding
laura-ding previously approved these changes Sep 4, 2020
Copy link
Contributor

@laura-ding laura-ding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice discovery!

@laura-ding laura-ding added the ready-for-testing PR: ready for the CI test label Sep 4, 2020
Copy link
Contributor

@dutor dutor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent

@dutor dutor merged commit 55be63e into vesoft-inc:master Sep 7, 2020
@nevermore3 nevermore3 deleted the add_test_case_rank branch September 7, 2020 11:18
xuguruogu pushed a commit to xuguruogu/nebula that referenced this pull request Sep 12, 2020
* add edge rank & fix test case

* fix test error

Co-authored-by: dutor <440396+dutor@users.noreply.github.com>
tong-hao pushed a commit to tong-hao/nebula that referenced this pull request Jun 1, 2021
* add edge rank & fix test case

* fix test error

Co-authored-by: dutor <440396+dutor@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants