bug fix: delete vertices processor may core, if this vertex also have edges and index #2335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dangleptr
previously approved these changes
Sep 2, 2020
critical27
previously approved these changes
Sep 2, 2020
panda-sheep
reviewed
Sep 2, 2020
tong-hao
pushed a commit
to tong-hao/nebula
that referenced
this pull request
Jun 1, 2021
… edges and index (vesoft-inc#2335) * delete vertices may core, if this vertex also have edges and index * different tagId will use the same vertexPrefix, so can not break if iterator an edge
yixinglu
added a commit
to yixinglu/nebula
that referenced
this pull request
Jan 31, 2023
* More lookup tests on ngdata * Test edge property of double and geography types * Restore geography test for lookup * comment back tests * More lookup test cases * restore ngdata tests * drop the used space * Fix failed * refine step * some variables in where clause of lookup statement * some variabes in yield clause of lookup statement * More yield variable test --------- Co-authored-by: Yee <2520865+yixinglu@users.noreply.github.com> Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get one core screen from BBS.
https://discuss.nebula-graph.com.cn/t/topic/1123/8
check all reference to getTagId,
find deleteVerticesProcessor call this without check if it is a vertex first.