bug fix: shutdown meta server before job manager init, may core #2332
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monadbobo
reviewed
Sep 1, 2020
|
|
dangleptr
reviewed
Sep 2, 2020
dangleptr
previously approved these changes
Sep 4, 2020
added 5 commits
September 7, 2020 14:33
liuyu85cn
dismissed stale reviews from bright-starry-sky, monadbobo, and dangleptr
via
42a902f
Codecov Report
@@ Coverage Diff @@
## master #2332 +/- ##
==========================================
- Coverage 86.46% 86.14% -0.33%
==========================================
Files 649 648 -1
Lines 64374 64878 +504
==========================================
+ Hits 55662 55887 +225
- Misses 8712 8991 +279
Continue to review full report at Codecov.
|
dangleptr
approved these changes
Sep 8, 2020
tong-hao
pushed a commit
to tong-hao/nebula
that referenced
this pull request
Jun 1, 2021
…ft-inc#2332) * bug fix: shutdown meta server before job manager init, may core * check if there is a stop before init, and if there is no init before stop * CI issue * fix clang-9 CI complait * clang-9 complaint keyword macro, lower compiler complaint clang-9 pragma... tired Co-authored-by: dangleptr <37216992+dangleptr@users.noreply.github.com>
yixinglu
pushed a commit
to yixinglu/nebula
that referenced
this pull request
Jan 31, 2023
Co-authored-by: jie.wang <38901892+jievince@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
shutdown job manager if its Initialization finished