fix multi daemon can't start on same node #2289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
critical27
requested review from
dutor,
darionyaphet,
dangleptr,
liuyu85cn,
bright-starry-sky and
panda-sheep
dangleptr
reviewed
Aug 11, 2020
src/daemons/MetaDaemon.cpp
Outdated
| @@ -170,7 +171,8 @@ int main(int argc, char *argv[]) { | |||
| } | |||
|
|
|||
| google::SetVersionString(nebula::versionString()); | |||
| folly::init(&argc, &argv, true); | |||
There was a problem hiding this comment.
why remove the init method.
There was a problem hiding this comment.
Because folly::init is almost same with init gflags + glog + singleton. You mean we init gflags twice?
I am confused, if you want to start multi instances on one host, each instance should have its own pid file in config file, right? |
|
Init gflags twice, one before |
xuguruogu
pushed a commit
to xuguruogu/nebula
that referenced
this pull request
Sep 12, 2020
* fix multi daemon can't start on same node * address comments
tong-hao
pushed a commit
to tong-hao/nebula
that referenced
this pull request
Jun 1, 2021
* fix multi daemon can't start on same node * address comments
yixinglu
pushed a commit
to yixinglu/nebula
that referenced
this pull request
Jan 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced in #2278, if we want to start multiple daemon with different flag file, the
FLAGS_pid_fileis the same because we have not initgflagsyet. (all of them is the default value ofFLAGS_pid_file, not the one in flag file)So we need to init
gflags,glogsby manual instead offolly::init.