Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed dangling pointer #228

Merged
merged 2 commits into from
Mar 22, 2019
Merged

Fixed dangling pointer #228

merged 2 commits into from
Mar 22, 2019

Conversation

dutor
Copy link
Contributor

@dutor dutor commented Mar 22, 2019

As title, this is a dangling pointer problem introduced by @dangleptr :->

@dutor dutor requested a review from dangleptr March 22, 2019 10:40
dangleptr
dangleptr reviewed Mar 22, 2019
View reviewed changes
Copy link
Contributor

@dangleptr dangleptr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My Fault! Good catch~

@nebula-community-bot
Copy link
Member

Unit testing passed.

@nebula-community-bot
Copy link
Member

Unit testing passed.

@dutor dutor merged commit 4f4eab0 into vesoft-inc:master Mar 22, 2019
@dutor dutor deleted the dangling-pointer branch March 22, 2019 11:10
tong-hao pushed a commit to tong-hao/nebula that referenced this pull request Jun 1, 2021
@dutor
Fixed dangling pointer (vesoft-inc#228)
95aa4a1
yixinglu added a commit to yixinglu/nebula that referenced this pull request Mar 21, 2022
@yixinglu
Use action to sync workflow (vesoft-inc#228)
4df6601
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dangleptr dangleptr dangleptr approved these changes

Assignees

@dangleptr dangleptr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dutor @nebula-community-bot @dangleptr